Closed tvcastillod closed 1 year ago
Hi @guaje,
I see that you requested a review from all but I see that this PR is a draft with WIP tag.
Is this PR ready for review? What is the status ? @tvcastillod, can you answer also ?
Is this PR ready for review? What is the status ? @tvcastillod, can you answer also ?
@skoudoro Not yet. I was waiting for today's meeting to know how to proceed with this PR, I received some comments that I will address soon, and when ready I will change the status and request the review again.
Thank you for the feedback!
Merging #791 (0a49b68) into master (73e0a1a) will decrease coverage by
0.09%
. The diff coverage is78.04%
.
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 84.41% 84.33% -0.09%
==========================================
Files 43 44 +1
Lines 10166 10356 +190
Branches 1381 1410 +29
==========================================
+ Hits 8582 8734 +152
- Misses 1227 1252 +25
- Partials 357 370 +13
Impacted Files | Coverage Δ | |
---|---|---|
fury/actor.py | 85.59% <41.93%> (-1.20%) |
:arrow_down: |
fury/actors/tensor.py | 100.00% <100.00%> (ø) |
@skoudoro @guaje would you mind taking a last look to see if there is anything else I need to adjust?
@JoaoDell, Can you look and review the shader part.
@ganimtron-10, can you look and review the python part.
Both, please, let @tvcastillod knows if you have any questions or if you see something.
After that, we can go ahead and merge this PR.
@skoudoro I did all the requested changes, I think now it is ready.
Hi, this PR aims to create a new ellipsoid actor defined with SDF and raymarching. The goal is to make an implementation that allows displaying a large amount of data, with good visual quality, and without compromising performance. I'm still working on improvements and ways to test the implementation.