Closed JoaoDell closed 1 year ago
Thanks @ganimtron-10, do you know how can I properly render it as code? This has been a struggle. I will see what is up with the image as it is loading when I build it here, does github have anything related to privacy on images or something? I checked and my repo is public
okay actually I forgot about the "::" usage will change that now 😵💫
Just updated with the code properly rendered. However, I am still trying to figure out the problem with the image. What I done was to upload it to a personal repo named gsoc_assets and get the image link by "Open image in another page". It seems my link is different of yours previous uploaded images as they are on user-images, how do you proceed with using images in rst @ganimtron-10?
It seems my link is different of yours previous uploaded images as they are on user-images, how do you proceed with using images in rst @ganimtron-10?
The approach you are using for adding image is more better and will work as a permanent solution, whereas the user-images are not under our control and may get deleted. Still if you want to know how I did it last time, you may have noticed that I had a PR #790 where I had added the images in the description I got link of those images and added them into my post. Otherwise when ever you paste an image in any issue body or PR body you get a user-image link that too works.
Hey @skoudoro I just made the changes you recommended. Is the way I changed the link the way you desired?
This might answer your question concerning link : https://stackoverflow.com/questions/37553750/how-can-i-link-reference-another-rest-file-in-the-documentation
currently, your change is incorrect concerning the link
Merging #800 (a053fe0) into master (4160b1d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #800 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 43 43
Lines 10173 10173
Branches 1383 1383
=======================================
Hits 8578 8578
Misses 1239 1239
Partials 356 356
I guess it may work now @skoudoro, i have built it locally with the instructions the documentation had about linking and it worked, see if it works for you. Thanks for the tip 👍
Here is my week 2 blogpost everyone, let me know of any changes needed