Open JoaoDell opened 1 year ago
thank you for your feedback. we will look at all this links.
Merging #804 (b611368) into master (3d53e48) will decrease coverage by
0.05%
. The diff coverage isn/a
.:exclamation: Current head b611368 differs from pull request most recent head bf2b91a. Consider uploading reports for the commit bf2b91a to get more accurate results
@@ Coverage Diff @@
## master #804 +/- ##
==========================================
- Coverage 84.43% 84.38% -0.05%
==========================================
Files 43 43
Lines 10274 10274
Branches 1393 1393
==========================================
- Hits 8675 8670 -5
- Misses 1239 1243 +4
- Partials 360 361 +1
After a pair with @devmessias, we made some progress on the FBO setup issue. Now, the FBO is sucessfully generated, and it seems ready to be drawn to. Apparently, the issue was that the context needed to have the window interactor initialized with ShowManager.initialize()
before the it was set to the FBO. I will prepare a better explaination and investigate further on why is that soon.
Hey @devmessias thanks for pointing those out, I have just updated this PR with my current progress:
Maybe @filipinascimento could have a better idea of what is happening as well.
Hey everyone, I just updated and completely refactored this PR as, as well as it is base program, as it went on a slight different direction in comparison to its original intetion. Everything seems to be working now, my only question is if it would be better if I closed this PR and opened a new one with a new branch containing only the recent commits, as the older ones have been completely replaced, or should I rebase it, I don't know. What should I do?
Anyway, this version is ready for review 👍
@ganimtron-10 I have fixed and updated most of your recommendations. Indeed, typedhint
isn't a FURY standard, but I will wait Filipi and Serge comments on that to change anything. Thanks for the comprehensive review!
Also, I just realised there is a native colormap generator in fury.colormp
named create_colormap()
so I just updated it with that.
Okay @skoudoro, I will be looking into the existing examples to understand how I should explain and detail this one so we can try using it as an example then, thanks for the opinion!
[UPDATED] Hello everyone, this PR contains an experimental implementation of Kernel Density Estimation calculations for a set of points. This uses some of fury's existing APIs and some straight vtk ones. This program may be a good example of shader usage and how to apply post-processing effects inside FURY. The result from running that should be:
Below, what is the idea here:
In more details, what is done:
SetOffscreenRendering(True)
.shaders.shader_apply_effects()
is used to tell OpenGL additive blending is desired for this code.matplotlib.colormaps
and passed to the billboard as a texture named"colormapTexture"
with the functioncolormap_to_texture()
window_to_texture()
Some minor details that may be useful for a better understanding of it: