fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
241 stars 181 forks source link

UI: Adding FileDialog UI #832

Open ganimtron-10 opened 1 year ago

ganimtron-10 commented 1 year ago

FileDialog is an important UI element needed for a variety of use case. Continuing #294 to add the required changes and updates.

TODO:

codecov[bot] commented 1 year ago

Codecov Report

Merging #832 (b95871b) into master (b29a518) will increase coverage by 0.07%. Report is 7 commits behind head on master. The diff coverage is 89.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   84.49%   84.57%   +0.07%     
==========================================
  Files          44       44              
  Lines       10454    10572     +118     
  Branches     1411     1419       +8     
==========================================
+ Hits         8833     8941     +108     
- Misses       1252     1257       +5     
- Partials      369      374       +5     
Files Changed Coverage Δ
fury/ui/elements.py 90.28% <89.60%> (+0.08%) :arrow_up:
skoudoro commented 1 year ago

What is the update concerning this PR @ganimtron-10?

ganimtron-10 commented 1 year ago

I have fixed the issues which were crucial and needed in this PR.

skoudoro commented 1 year ago

@tvcastillod and @JoaoDell, Can you look at this PR ? Thank you

ganimtron-10 commented 1 year ago

Hey @JoaoDell @tvcastillod , Heres the blog link to get more understanding about what I did in this PR https://blogs.python-gsoc.org/en/ganimtron_10s-blog-copy-2/week-12-filedialog-quest-begins/

JoaoDell commented 1 year ago

Hey @JoaoDell @tvcastillod , Heres the blog link to get more understanding about what I did in this PR https://blogs.python-gsoc.org/en/ganimtron_10s-blog-copy-2/week-12-filedialog-quest-begins/

Just checked your blogpost and I have no more questions. Also I noticed you have fixed the directory textblock clipping, so everything seems in place now, good job