search

fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
226 stars 165 forks source link

UI: Adding Text Offset to contain text into the Background #837

Closed ganimtron-10 closed 11 months ago

ganimtron-10 commented 11 months ago

We noticed an issue with the TextBox2D which was, the Text was sometimes touching or getting a bit outside of the background boundary. To fix this I propose to offset the text actor in the TextBlock2D with some offset amount which would contain the text inside the background bounding box.

codecov[bot] commented 11 months ago

Codecov Report

Merging #837 (d6b6c8d) into master (b29a518) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files          44       44           
  Lines       10454    10457    +3     
  Branches     1411     1411           
=======================================
+ Hits         8833     8836    +3     
  Misses       1252     1252           
  Partials      369      369
Files Changed Coverage Δ
fury/ui/core.py 93.46% <100.00%> (+0.03%) :arrow_up:
ganimtron-10 commented 11 months ago

This PR needs more discussion. So closing this PR for now!