fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
226 stars 165 forks source link

Added Dark mode, Fixed Search Bar for documentation site #868

Closed deka27 closed 3 months ago

deka27 commented 3 months ago

Introduction of Dark Mode & Search Bar Fix

Description

Related Issues

Changes Made

Screenshots

Light Mode image

Dark Mode image

Checklist

Additional Notes

deka27 commented 3 months ago

@skoudoro I noticed a small mistake with my last PR. Created this new one for the fix.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.42%. Comparing base (ea0fb16) to head (18eba41).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fury-gl/fury/pull/868/graphs/tree.svg?width=650&height=150&src=pr&token=wrshJ6dyDs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl)](https://app.codecov.io/gh/fury-gl/fury/pull/868?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) ```diff @@ Coverage Diff @@ ## master #868 +/- ## ======================================= Coverage 84.42% 84.42% ======================================= Files 44 44 Lines 10529 10529 Branches 1418 1418 ======================================= Hits 8889 8889 Misses 1268 1268 Partials 372 372 ```
deka27 commented 3 months ago

Thank you @deka27,

Looks good to me. merging.

ps: there is a small issue, you need to click twice on dark/light button to see the change, which is strange. But for now, it is ok

So, actually, you have to click twice because there are 3 modes,

System mode is if you want the site to automatically load according to the OS settings, it comes from the theme itself.

skoudoro commented 3 months ago

System mode is if you want the site to automatically load according to the OS settings, it comes from the theme itself.

Good to know! thanks !