fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
226 stars 165 forks source link

ODF actor implemented with Ray Tracing #869

Open tvcastillod opened 3 months ago

tvcastillod commented 3 months ago

This PR aims to create a new odf actor defined with raymarching based on the paper Ray Tracing Spherical Harmonics Glyphs . Work is still in progress.

A visual comparison with the current implementation of fury using polygons image

An example is provided showing that it supports displaying multiple glyphs, and with different SH degree. image

pep8speaks commented 3 months ago

Hello @tvcastillod, Thank you for updating!

Line 4030:80: E501 line too long (80 > 79 characters)

Line 968:41: E203 whitespace before ',' Line 968:56: E202 whitespace before ']' Line 972:22: E128 continuation line under-indented for visual indent Line 974:1: W293 blank line contains whitespace

Line 5:1: E302 expected 2 blank lines, found 1 Line 6:4: E111 indentation is not a multiple of four Line 7:4: E111 indentation is not a multiple of four Line 11:4: E111 indentation is not a multiple of four Line 13:4: E111 indentation is not a multiple of four Line 14:4: E111 indentation is not a multiple of four Line 22:4: E111 indentation is not a multiple of four Line 24:4: E111 indentation is not a multiple of four Line 25:4: E111 indentation is not a multiple of four Line 41:4: E111 indentation is not a multiple of four

To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-03-29 15:15:28 UTC
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.72180% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 84.47%. Comparing base (ea0fb16) to head (f4824f6). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fury-gl/fury/pull/869/graphs/tree.svg?width=650&height=150&src=pr&token=wrshJ6dyDs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl)](https://app.codecov.io/gh/fury-gl/fury/pull/869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) ```diff @@ Coverage Diff @@ ## master #869 +/- ## ========================================== + Coverage 84.42% 84.47% +0.05% ========================================== Files 44 46 +2 Lines 10529 10662 +133 Branches 1418 1439 +21 ========================================== + Hits 8889 9007 +118 - Misses 1268 1276 +8 - Partials 372 379 +7 ``` | [Files](https://app.codecov.io/gh/fury-gl/fury/pull/869?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) | Coverage Δ | | |---|---|---| | [fury/actors/odf.py](https://app.codecov.io/gh/fury-gl/fury/pull/869?src=pr&el=tree&filepath=fury%2Factors%2Fodf.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9hY3RvcnMvb2RmLnB5) | `100.00% <100.00%> (ø)` | | | [fury/texture/utils.py](https://app.codecov.io/gh/fury-gl/fury/pull/869?src=pr&el=tree&filepath=fury%2Ftexture%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS90ZXh0dXJlL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | | | [fury/utils.py](https://app.codecov.io/gh/fury-gl/fury/pull/869?src=pr&el=tree&filepath=fury%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS91dGlscy5weQ==) | `91.65% <80.00%> (-0.35%)` | :arrow_down: | | [fury/actor.py](https://app.codecov.io/gh/fury-gl/fury/pull/869?src=pr&el=tree&filepath=fury%2Factor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9hY3Rvci5weQ==) | `85.02% <65.71%> (-0.58%)` | :arrow_down: |