Open tvcastillod opened 3 months ago
Hello @tvcastillod, Thank you for updating!
fury/actor.py
:Line 4030:80: E501 line too long (80 > 79 characters)
fury/tests/test_utils.py
:Line 968:41: E203 whitespace before ',' Line 968:56: E202 whitespace before ']' Line 972:22: E128 continuation line under-indented for visual indent Line 974:1: W293 blank line contains whitespace
fury/texture/tests/test_utils.py
:Line 5:1: E302 expected 2 blank lines, found 1 Line 6:4: E111 indentation is not a multiple of four Line 7:4: E111 indentation is not a multiple of four Line 11:4: E111 indentation is not a multiple of four Line 13:4: E111 indentation is not a multiple of four Line 14:4: E111 indentation is not a multiple of four Line 22:4: E111 indentation is not a multiple of four Line 24:4: E111 indentation is not a multiple of four Line 25:4: E111 indentation is not a multiple of four Line 41:4: E111 indentation is not a multiple of four
To test for issues locally, pip install flake8
and then run flake8 fury
.
Attention: Patch coverage is 88.72180%
with 15 lines
in your changes are missing coverage. Please review.
Project coverage is 84.47%. Comparing base (
ea0fb16
) to head (f4824f6
). Report is 2 commits behind head on master.
This PR aims to create a new odf actor defined with raymarching based on the paper Ray Tracing Spherical Harmonics Glyphs . Work is still in progress.
A visual comparison with the current implementation of fury using polygons
An example is provided showing that it supports displaying multiple glyphs, and with different SH degree.