search

fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
241 stars 181 forks source link

Make PyGLTFLib an optional dependency #873

Open guaje opened 6 months ago

guaje commented 6 months ago

Is your feature request related to a problem? Please describe. PyGLTFLib usage in the codebase is lower than some optional dependencies, such as DIPY.

Describe the solution you'd like Make PyGLTFLib an optional dependency.

noobyco commented 6 months ago

moving PyGLTFLib from requirements/default to requirements/optional shuold do the thing. I'm on it.

guaje commented 6 months ago

moving PyGLTFLib from requirements/default to requirements/optional shuold do the thing. I'm on it.

You also need to look for its usage in the codebase and ensure it doesn't throw errors when pyGLTFlib is not installed in the user's environment.

noobyco commented 6 months ago

moving PyGLTFLib from requirements/default to requirements/optional shuold do the thing. I'm on it.

You also need to look for its usage in the codebase and ensure it doesn't throw errors when pyGLTFlib is not installed in the user's environment.

Yeah sure!

robinroy03 commented 5 months ago

@noobyco, you still working on this issue? I'll be happy to help.

noobyco commented 5 months ago

@noobyco, you still working on this issue? I'll be happy to help.

I have created a PR https://github.com/fury-gl/fury/pull/875 but I do need to check one thing mentioned below. Yup, we can work together if you want just hit me on Twitter https://twitter.com/noobyco :)

You also need to look for its usage in the codebase and ensure it doesn't throw errors when pyGLTFlib is not installed in the user's environment.

janhavi-naik14 commented 4 months ago

1)Update dependency management: Modify requirements.txt, create requirements-optional.txt, and update setup.py. 2)Modify the codebase: Use try...except for importing PyGLTFLib and conditionally handle its functionality. 3)Update documentation: Inform users about the optional dependency and how to install it. 4)Test the changes: Verify that the application works with and without the optional dependency.