search

fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
226 stars 165 forks source link

Wass contributions #882

Closed WassCodeur closed 2 months ago

WassCodeur commented 2 months ago

Refactor animation code and fix imports [pycodestyle]

pep8speaks commented 2 months ago

Hello @WassCodeur, thank you for submitting the Pull Request!

Line 9:1: F401 'fury.window.ShowManager' imported but unused Line 9:1: F401 'fury.window.Scene' imported but unused

To test for issues locally, pip install flake8 and then run flake8 fury.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.43%. Comparing base (14851c6) to head (02c3265).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fury-gl/fury/pull/882/graphs/tree.svg?width=650&height=150&src=pr&token=wrshJ6dyDs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl)](https://app.codecov.io/gh/fury-gl/fury/pull/882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) ```diff @@ Coverage Diff @@ ## master #882 +/- ## ======================================= Coverage 84.43% 84.43% ======================================= Files 44 44 Lines 10537 10537 Branches 1423 1423 ======================================= Hits 8897 8897 Misses 1266 1266 Partials 374 374 ``` | [Files](https://app.codecov.io/gh/fury-gl/fury/pull/882?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) | Coverage Δ | | |---|---|---| | [fury/animation/helpers.py](https://app.codecov.io/gh/fury-gl/fury/pull/882?src=pr&el=tree&filepath=fury%2Fanimation%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9hbmltYXRpb24vaGVscGVycy5weQ==) | `92.00% <ø> (ø)` | | | [fury/animation/timeline.py](https://app.codecov.io/gh/fury-gl/fury/pull/882?src=pr&el=tree&filepath=fury%2Fanimation%2Ftimeline.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9hbmltYXRpb24vdGltZWxpbmUucHk=) | `56.52% <66.66%> (ø)` | | | [fury/animation/animation.py](https://app.codecov.io/gh/fury-gl/fury/pull/882?src=pr&el=tree&filepath=fury%2Fanimation%2Fanimation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9hbmltYXRpb24vYW5pbWF0aW9uLnB5) | `68.78% <77.77%> (ø)` | |