search

fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
241 stars 181 forks source link

Fix pycodestyle stream #885

Closed WassCodeur closed 5 months ago

WassCodeur commented 5 months ago

fix: style error using ruff [

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 85.44304% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 84.43%. Comparing base (14851c6) to head (4e767ff).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fury-gl/fury/pull/885/graphs/tree.svg?width=650&height=150&src=pr&token=wrshJ6dyDs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl)](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) ```diff @@ Coverage Diff @@ ## master #885 +/- ## ========================================== - Coverage 84.43% 84.43% -0.01% ========================================== Files 44 44 Lines 10537 10534 -3 Branches 1423 1423 ========================================== - Hits 8897 8894 -3 Misses 1266 1266 Partials 374 374 ``` | [Files](https://app.codecov.io/gh/fury-gl/fury/pull/885?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) | Coverage Δ | | |---|---|---| | [fury/animation/helpers.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fanimation%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9hbmltYXRpb24vaGVscGVycy5weQ==) | `92.00% <ø> (ø)` | | | [fury/colormap.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fcolormap.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9jb2xvcm1hcC5weQ==) | `93.26% <ø> (ø)` | | | [fury/convert.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fconvert.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9jb252ZXJ0LnB5) | `80.00% <ø> (ø)` | | | [fury/deprecator.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fdeprecator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9kZXByZWNhdG9yLnB5) | `94.24% <100.00%> (ø)` | | | [fury/layout.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Flayout.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9sYXlvdXQucHk=) | `98.61% <100.00%> (ø)` | | | [fury/molecular.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fmolecular.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9tb2xlY3VsYXIucHk=) | `100.00% <100.00%> (ø)` | | | [fury/primitive.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fprimitive.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9wcmltaXRpdmUucHk=) | `95.58% <100.00%> (ø)` | | | [fury/stream/server/main.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Fstream%2Fserver%2Fmain.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS9zdHJlYW0vc2VydmVyL21haW4ucHk=) | `41.57% <ø> (ø)` | | | [fury/testing.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Ftesting.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS90ZXN0aW5nLnB5) | `89.41% <100.00%> (ø)` | | | [fury/transform.py](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree&filepath=fury%2Ftransform.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl#diff-ZnVyeS90cmFuc2Zvcm0ucHk=) | `100.00% <100.00%> (ø)` | | | ... and [14 more](https://app.codecov.io/gh/fury-gl/fury/pull/885?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fury-gl) | |
skoudoro commented 5 months ago

Hi @WassCodeur,

Thank you for doing this.

As you can see here on the ci, there are still some issues: https://github.com/fury-gl/fury/actions/runs/8886182798/job/24399145996?pr=885#step:4:195

Can you address them? Then, it will be ready for review

WassCodeur commented 5 months ago

HI @skoudoro thank you for your feedback.

Sure, I can adress them

pep8speaks commented 5 months ago

Hello @WassCodeur, Thank you for updating!

Line 1127:80: E501 line too long (84 > 79 characters)

To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-05-02 14:15:34 UTC
skoudoro commented 5 months ago

Hi @WassCodeur,

There are still some issue but I will go ahead and merge. Thank you for doing this