fury-gl / fury

FURY - Free Unified Rendering in pYthon.
https://fury.gl
Other
241 stars 181 forks source link

NF: Add lazy_loader feature in FURY #907

Closed WassCodeur closed 2 months ago

WassCodeur commented 3 months ago

This pull request introduces the lazy_loader feature to optimize module loading in the FURY . Lazy loading improves performance by deferring the loading of modules until they are actually needed, thus reducing startup times and memory footprint.

Changes included in this PR:

This feature aims to improve the user experience by speeding up application start-up and improving overall performance in scenarios where not all modules are immediately required.

skoudoro commented 2 months ago

Thank you for this. Can you rebase ?

deka27 commented 2 months ago

Hi @WassCodeur , why does this have the keyword decorator commit? Also, I believe you should have a look at the lazy loading implementation in Scikit-Image. You will have to make changes in pyproject.toml

https://github.com/fury-gl/fury/blob/43540d3534e907241c84969915d38a072d2ee66c/pyproject.toml#L44C1-L52C2

WassCodeur commented 2 months ago

Hi @deka27! Thank you. By the way, I had created the lazy_loader branch from the keyword_only branch. Thanks a lot for the reminder to update the pyproject.toml.

deka27 commented 2 months ago

Okay, I understand. I feel you could have implemented as a new feature branch only (it will be tough to review both features at once, so u might need to rebase properly). Also u might need py.typed file (this is so that type_stub files are compiled properly).

WassCodeur commented 2 months ago

Okay, thanks a lot @deka27 . I'll look into integrating py.typed.