furybee / chrome-tab-modifier

Take control of your tabs
https://chrome.google.com/webstore/detail/tab-modifier/hcbgadmbdkiilgpifjgcakjehmafcjai
MIT License
571 stars 107 forks source link

Rules aren't Applied on ReOpen #379

Closed fabianbanu closed 1 month ago

fabianbanu commented 2 months ago

Rules are not applied after closing and reopening the tab.

Each time I reopen the url, I must save the rule again to get the custom title and icon back.

This is on Google Chrome and Opera Browser.

sebastienfontaine commented 2 months ago

Hello @fabianbanu,

I am unable to reproduce your issue. Could you please use the template below to provide more details?

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Extension version:** `X.Y.Z`

_Can be found here: chrome://extensions/?id=hcbgadmbdkiilgpifjgcakjehmafcjai_

**Additional context**
Add any other context about the problem here.

Best regards,

fabianbanu commented 2 months ago

Hi @sebastienfontaine

I've figured out how to reproduce this bug!

I realize I often visit the same set of links for work from a folder of bookmarks in Chrome. When the page is first opened from specifically the bookmark, the rules for that URL do not apply until I refresh the page.

I think this is due to a discrepancy between saved bookmark and actual page URL, probably solved by using 'contains' instead of 'exact' for the rule.

Perhaps this doesn't need addressing.

While I'm here, I might recommend plugging this website https://favicon.io/emoji-favicons/ As it has been the best resource for finding good links for emoji Favicon!

Thanks for the great product.

sebastienfontaine commented 1 month ago

Hi! This is probably resolved by using ‘contains’ instead of ‘exact’ for the rule. Thanks for sharing the link to the favicon resource and for your feedback on the extension! I appreciate it! 🥳