fus-marcom / bulletin-react

React/Redux version of the University Bulletin
MIT License
42 stars 18 forks source link

Query all posts and add all button to category drawer #24

Closed DennyScott closed 7 years ago

DennyScott commented 7 years ago

Pr for #18

I didn't want to change to much with the general structure, so I added a stateless component in drawer.js to handle the All Category button. I also created a new smart component for the all posts. It could be it's own file, but since most of the logic retained still to category, I left it in the category view. I can always extract it more.

I was not able to use the orderBy keyword in apollo. Don't have a ton of GraphQL/Apollo experience, so lemme know if you have any ideas :).

screen shot 2017-10-18 at 2 59 53 pm
DennyScott commented 7 years ago

Mmm, I notice the home page now shows all posts. Do you want the category page to show all posts, or would you prefer the "all" button link back to the home page?

JesseRWeigel commented 7 years ago

Eventually the home page will only show the posts for the current week, so All/Category should be its own page.

JesseRWeigel commented 7 years ago

Thanks for this @DennyScott !