search

fus-marcom / bulletin-react

React/Redux version of the University Bulletin
MIT License
42 stars 18 forks source link

Filled Space in Grid and fixed error handler #30

Closed pantharshit00 closed 7 years ago

pantharshit00 commented 7 years ago

(Closes #16 )

Hey @JesseRWeigel In this PR I have fixed the gaps in the grid. It was a quick an easy fix. Just specified the height to 100%. I have also fixed the error handler as we changed our renderer to GridRenderer component.

HOPE THIS HELPS YOU 

          HARSHIT
JesseRWeigel commented 7 years ago

I think we need a solution that allows for different card heights. Otherwise we will end up with too much white space in cards with less content, like this: image

I think something like to potential solution mentioned in #16 will work.

I will leave the PR open in case you want to edit it.

pantharshit00 commented 7 years ago

OK no probs. But I tried masonry. It is hard to implement with material UI

pantharshit00 commented 7 years ago

Closing this as to work on masonry

pantharshit00 commented 7 years ago

47 now fix this problem