search

fus-marcom / bulletin-react

React/Redux version of the University Bulletin
MIT License
42 stars 18 forks source link

Show category name in post preview #31

Closed SebastianCApostolescu closed 7 years ago

SebastianCApostolescu commented 7 years ago

Pretty straightforward. Added an attachment button. This will need further implementation since I don't really know how it should look. Also, I moved the post image under the title and date, don't really know if it's good or not. Check it out.

PD: It also includes the npm start fix for Windows, which by the time I'm writing this I think you already merged a previous PR.

Side Note: Just notices that GMail has GitHub link support https://i.imgur.com/rWi7URt.png

JesseRWeigel commented 7 years ago

Great job @SebastianCApostolescu ! Here is how the attachments are currently displayed: image

Also, I think the title, date and category should be below the image like this: image

If you have time to adjust this PR, that would be awesome, otherwise I can make the changes to this branch and merge afterward. Just let me know.

SebastianCApostolescu commented 7 years ago

Moved back the image were it was. For the attachment maybe it's better to show me in the stream how you want it.

SebastianCApostolescu commented 7 years ago

Update... Something similar?

test

SebastianCApostolescu commented 7 years ago

Added text (which needs to be truncated, Issue #32 ) to the Post Preview. Check previous photo to see how it looks.

JesseRWeigel commented 7 years ago

Thank you @SebastianCApostolescu ! You are awesome!