search

fus-marcom / bulletin-react

React/Redux version of the University Bulletin
MIT License
42 stars 18 forks source link

Implement Login with Microsoft ID #64

Open JesseRWeigel opened 6 years ago

JesseRWeigel commented 6 years ago

Can we implement something like this? https://blog.talentica.com/2017/06/23/implement-microsoft-login-in-a-react-js-app/

We would need some way to use a whitelist and only accept @franciscan.edu addresses.

@pantharshit00 since you created the login system, I would like your opinion on this please.

pantharshit00 commented 6 years ago

We should use passport js with microsoft as we also need to secure our graphql API that is being routed through our servers. I dont know but I guess making authentication client side we will not be able to protect our WP which make authentication useless. I am going to implement this using passport js.

pantharshit00 commented 6 years ago

Also we have cookie based auth already set in react so no need of writing any more code other than chaging email form to sign in with microsoft

pantharshit00 commented 6 years ago

implemented in #65