Auto close UX tags - Githubissues

fuse-open / atom-plugin

Fuse Open plugin for Atom

MIT License

30 stars 11 forks source link

Auto close UX tags #31

Closed jsbeckr closed 7 years ago

jsbeckr commented 7 years ago

Regarding: #28

I borrowed some code from https://github.com/awaw00/autoclose and added a few fixes, which makes it more convenient to use.

Features:

Typing > after <TAG auto closes with </TAG>
Typing / after <TAG auto closes with >
Typing / inside of <TAG></TAG> removes </TAG> (only if in the same line)

Tapped commented 7 years ago

Hi, thank you for your pull request :) However we feel that this feature is slightly out of scope for the purpose of this plugin. There are already plugins doing XML tags closing, including the one you mentioned in the issue: https://atom.io/packages/autoclose-tags. I would suggest that a pull-request is made in one of the existing auto close packages, with your fixes.

Does this sound reasonable to you, or are there something we have missed?

jsbeckr commented 7 years ago

Hi,

yeah that's understandable. I will contribute my change to the autoclose project. :)