search

fuse-open / fuselibs

Fuselibs is the Uno-libraries that provide the UI framework used in Fuse apps
https://npmjs.com/package/@fuse-open/fuselibs
MIT License
176 stars 72 forks source link

Unable to restrict orientation to portrait #1374

Closed AndrewEQ closed 3 years ago

AndrewEQ commented 4 years ago

Hi guys,

There's a property that deals with the restriction of the orientation of the app:

https://fuseopen.com/docs/basics/uno-projects.html#mobile-orientations

When set to "Portrait", it doesn't limit the app to portrait anymore on iOS.

I believe its to do with the recently merged change: https://github.com/fuse-open/fuselibs/pull/1354

I think if a developer restricts their app to a specific orientation, then they are unlikely to want to define every pages orientation.

So the feature should probably only be enabled when the Mobile.Orientations setting is set to Auto (which is the Mobile.Orientations default).

Or if the dev sets the Mobile.Orientations to Landscape for instance, that they could only choose between "LandscapeLeft" and "LandscapeRight" when setting their pages orientation, so the orientation feature could still exist all the time, just that it needs to take into account the Mobile.Orientations setting.

ichan-mb commented 4 years ago

Thanks for reporting, I'll try to investigate it.