search

fuse-open / fuselibs

Fuselibs is the Uno-libraries that provide the UI framework used in Fuse apps
https://npmjs.com/package/@fuse-open/fuselibs
MIT License
176 stars 72 forks source link

Android: don't add BACKGROUND_LOCATION to manifest #1411

Closed mortend closed 3 years ago

mortend commented 3 years ago

Apps with this permission declared in their manifest are rejected when submitting to Google Play, unless providing a video demonstrating how this functionality is used in the app.

The problem with some apps is that they aren't really using this feature so there's nothing to demonstrate, and the only way to publish currently is to manually edit AndroidManifest.xml, remove the permission, re-run build.sh, and finally submit the modified AAB/APK.

This patch addresses the problem by not adding this permission automatically. Apps that really need it will be required to add it manually. Please report issues if this becomes a problem for anyone.

Closes #1402

This PR contains:

mortend commented 3 years ago
ckarmy commented 3 years ago

Thanks! And how can I add the permission? I have another app that use it

mortend commented 3 years ago

@ckarmy You can add the permission by adding the following UXL file in your project.

AndroidBackgroundLocation.uxl:

<Extensions Backend="CPlusPlus" Condition="ANDROID">
    <Require AndroidManifest.Permission="android.permission.ACCESS_BACKGROUND_LOCATION" />
</Extensions>
ckarmy commented 3 years ago

@ckarmy You can add the permission by adding the following UXL file in your project.

AndroidBackgroundLocation.uxl:

<Extensions Backend="CPlusPlus" Condition="ANDROID">
    <Require AndroidManifest.Permission="android.permission.ACCESS_BACKGROUND_LOCATION" />
</Extensions>

Great! Thanks!