search

fusepilot / create-cep-extension

A near zero config approach to creating CEP extensions with Webpack and React.
Other
87 stars 15 forks source link

Currently only supports AEFT, use app ID in manifest #3

Closed kennethormandy closed 7 years ago

kennethormandy commented 7 years ago

Expected

I should be able to supply the EXTENSION_APP_IDS environment variable to another application (ex. IDSN) and set a specific version, and have Create CEP Extension build the manifest so it runs in that application.

Actual

I can supply the EXTENSION_APP_IDS, but the manifest always is for AEFT. There’s no way to pass along a specific version of the application.

This pull request replaces the hard-coded AEFT with the environment variable, and adds a EXTENSION_APP_VERSIONS environment variable for the version. You can still pass multiple version numbers for one app (ex. "[13.0,15.9]" which I left as the default), but you still can’t add multiple applications.

It didn’t seem like environment variables would work as well to configure more than one app, what do you think? I think the package.json could be an alternate place to hold the config, maybe other than the stuff you wouldn’t necessarily want to commit like the password.

Maybe in engines?

"engines": {
  "node": "6.9.x",
  "npm": "3.x",
  "AEFT": ["13.0", "15.9"],
  "IDSN": "11.0"
}

…or it could be all within its own Create CEP Extension config object?

fusepilot commented 7 years ago

Cool, thanks! I'm going to merge this and continue the conversation in a new pull request.