search

fusepool / tables-ld

Funding opportunities
2 stars 1 forks source link

don't rely on specific implementation but on interfaces #1

Closed retog closed 10 years ago

retog commented 10 years ago

I see these dependencies:

           <dependency>
                    <groupId>org.apache.clerezza</groupId>
                    <artifactId>rdf.jena.sparql</artifactId>
                    <version>0.6</version>
                    <scope>compile</scope>
            </dependency>

            <dependency>
                    <groupId>org.apache.clerezza</groupId>
                    <artifactId>rdf.jena.parser</artifactId>
                    <version>0.11</version>
                    <scope>compile</scope>
            </dependency>

These are providers of particular implemenations. Code should not rely on them, so in a pom they should show up at most as runtime dependency (but here they should be removed).

retog commented 10 years ago

@luigiselmi Any update on this? I noticed the issue also applies to silklinkingengine

luigiselmi commented 10 years ago

These dependencies are not needed. They have been removed. In silklinkingengine project there are no such dependencies but a different dependency on rdf.jena.serializer has been removed as not needed.

luigiselmi commented 10 years ago

Unneeded and outdated. One of the two. The parser implementation is needed for tests.

Date: Fri, 11 Jul 2014 13:51:13 -0700 From: notifications@github.com To: tables-ld@noreply.github.com CC: selmi_luigi@hotmail.com Subject: Re: [tables-ld] don't rely on specific implementation but on interfaces (#1)

in some other projects it's even worse: unneded and outdated:

grep "tId>org.apache.clerezza" find . -name pom.xml

./fusepool-dlc-pubmed/pom.xml: org.apache.clerezza.rdf.jena.parser

./fusepool-dlc-projects/pom.xml: org.apache.clerezza.rdf.jena.parser

./fusepool-dlc-patents/pom.xml: org.apache.clerezza.rdf.jena.parser

but yes, I'll fix that.

— Reply to this email directly or view it on GitHub.