search

fusesource / jansi

Jansi is a small java library that allows you to use ANSI escape sequences to format your console output which works even on windows.
http://fusesource.github.io/jansi/
Apache License 2.0
1.11k stars 140 forks source link

fix IS_CYGWIN (was not working anyway), replaced by test on env variable ConEmuANSI=ON #146

Closed Arnaud-Nauwynck closed 5 years ago

Arnaud-Nauwynck commented 5 years ago

…was typo "!" IS_CYGWIN = ... !"cygwin".equals(System.getenv("TERM") instead of IS_CYGWIN = ... "cygwin".equals(System.getenv("TERM")

notice that in a windows cmd.exe console, the jansi mode "WINDOWS" works fine ... this is independent of the fact that the process "bash.exe" from cygwin is running

notice also that on windows, a very frequent usage is to use cmder console emulator (https://cmder.net/) + cygwin The cmder console define several environment variables, including ConEmuANSI="ON" which could be tested to use the standard ANSI mode of jansi

hboutemy commented 5 years ago

kept ConEmu support part of the PR didn't merge the Cygwin removal: absolutely independent, and you have no proof that there is any issue with the detection as it was written