search

fusesource / jansi

Jansi is a small java library that allows you to use ANSI escape sequences to format your console output which works even on windows.
http://fusesource.github.io/jansi/
Apache License 2.0
1.11k stars 140 forks source link

Fix license name #229

Closed michael-o closed 2 years ago

michael-o commented 2 years ago

The license name in the POM is wrong. It must read: Apache License, Version 2.0

See: https://github.com/apache/maven-apache-parent/blob/e3a75f29af4e8ab443ee4f2ee702c766a2f017f2/pom.xml#L45-L49

gnodet commented 2 years ago

I suppose you meant the following ?

      <name>The Apache Software License, Version 2.0</name>
michael-o commented 2 years ago

I suppose you meant the following ?

      <name>The Apache Software License, Version 2.0</name>

Yes, that snippet is wrong.

JakeWharton commented 2 years ago

Per https://maven.apache.org/pom.html#Licenses the use of a SPDX identifier is now recommended so given https://spdx.org/licenses/Apache-2.0.html it should actually be "Apache-2.0".

michael-o commented 2 years ago

Per https://maven.apache.org/pom.html#Licenses the use of a SPDX identifier is now recommended so given https://spdx.org/licenses/Apache-2.0.html it should actually be "Apache-2.0".

This maybe true, but MPIR's dependency report aggregates by name alomst every one is using the canonical name, not the SPDX id.

JakeWharton commented 2 years ago

It's not clear why we should honor some random tool's behavior over the canonical recommendation from the specification for the file in which this data exists.

Perhaps recommended to that tool that they should normalize the data toward the SPDX identifiers rather than naive name-based grouping.

gnodet commented 2 years ago

Ideally, the MPIR's dependency report would read https://github.com/spdx/license-list-data/blob/master/json/licenses.json and allows aggregating the full name with the short identifiers.

michael-o commented 2 years ago

Ideally, the MPIR's dependency report would read https://github.com/spdx/license-list-data/blob/master/json/licenses.json and allows aggregating the full name with the short identifiers.

True, didn't know about this one. Please raise a JIRA issue for this. Surprisingly, this does not match the name in the original license.

gnodet commented 2 years ago

Fixed with https://github.com/fusesource/jansi/commit/00e15cb1fab9117790580a412f7d54f2c08d2f11 and https://issues.apache.org/jira/projects/MPIR/issues/MPIR-407 was raised.