search

fusesource / jansi

Jansi is a small java library that allows you to use ANSI escape sequences to format your console output which works even on windows.
http://fusesource.github.io/jansi/
Apache License 2.0
1.1k stars 139 forks source link

Fix FFM backend on Windows #263

Closed Glavo closed 9 months ago

Glavo commented 9 months ago

The FFM backend appears to be untested and will crash when using it, I'm trying to solve these problems.

There are more issues waiting to be fixed, WIP.

Glavo commented 9 months ago

It no longer crashes, but some features still don't work.

Glavo commented 9 months ago

It mostly works now, but I suspect there are hidden bugs that will need to be fixed.

Glavo commented 9 months ago

This PR is ready for review.

@gnodet I think it would be better to move AnsiConsoleSupport and org.fusesource.jansi.ffm to org.fusesource.jansi.internal?

They are the same low-level API as the existing CLibrary/Kernel32 and do not seem to be suitable as part of the public API.

I'd like to do some refactoring before they are officially released, what do you think?

gnodet commented 9 months ago

This PR is ready for review.

@gnodet I think it would be better to move AnsiConsoleSupport and org.fusesource.jansi.ffm to org.fusesource.jansi.internal?

They are the same low-level API as the existing CLibrary/Kernel32 and do not seem to be suitable as part of the public API.

I'd like to do some refactoring before they are officially released, what do you think?

Yes, that makes sense.

Glavo commented 9 months ago

This PR is ready for review. @gnodet I think it would be better to move AnsiConsoleSupport and org.fusesource.jansi.ffm to org.fusesource.jansi.internal? They are the same low-level API as the existing CLibrary/Kernel32 and do not seem to be suitable as part of the public API. I'd like to do some refactoring before they are officially released, what do you think?

Yes, that makes sense.

Okay, when this PR is merged, I will do this work in a new PR.