search

fusesource / leveldbjni

A Java Native Interface to LevelDB
BSD 3-Clause "New" or "Revised" License
537 stars 143 forks source link

support for filter policies (bloom filter) #12

Closed phraktle closed 11 years ago

phraktle commented 12 years ago

Is there suport planned for filters?

(see section titled Filters in the LevelDB docs)

chirino commented 11 years ago

Not yet. But patches/pull requests are encouraged!

kamstrup commented 11 years ago

I have started working on this here https://github.com/kamstrup/leveldbjni/commit/bd9e470193e6e18925dfd92148687a0cb3c9e920

I am not totally sure how to expose it in the API in a clean way - since we're exposed through a 3rd party Options API in JniDBFactory.open(). I am thinking of simply adding an extra method JniDBFactory.openWithBloomFilterBits(File, Options, int); but it is kinda-not-very-elegant - but otoh I would like to start the particular yak shaving of adding it to the iq80 leveldb lib... Any comments?

Why was this issue closed?

kamstrup commented 11 years ago

Sorry, "I would not like to start that particular yak shaving" :-)

phraktle commented 11 years ago

Hi @chirino,

It would be great if you could reopen this issue, and consider incorporating the patch from @kamstrup...

Thanks, Viktor