search

fushatech / tahir

Browser extension to avoid haram images & videos on the Internet
The Unlicense
54 stars 9 forks source link

Feature Request: Permanent Whitelist #9

Open fushatech opened 6 years ago

fushatech commented 6 years ago

Users have requested the ability to add domains to a whitelist that will not be blurred, even if Tahir is on. Tahir popup modal should have an area to "Manage Whitelist" where domains can be added/removed. When Tahir runs on the page, it should first check to see if the current tab domain is included on the whitelist, before automatically blurring.

fushatech commented 4 years ago

Tahir Spec: Whitelist Feature

Problem: When a user turns Tahir off for a website, they sometimes forget Tahir is off when loading a new tab and then accidentally view impermissible images.

Solution: Allow users to white-list safe domains, so they never need to manually turn Tahir off. Instead, white-listed domains will be excluded from Tahir filtering.

Implementation

  1. Allow user to add or delete whitelist website domains in the Tahir popup modal. This should be saved in the 'settings' localstorage that is already in use.

  2. When Tahir is on, it first checks whether the current tab URL matches any domain in the whitelist. If it matches, no filtering is provided. If it is not, default filtering is provided.

  3. When checking the websitelist, Tahir should check if the current tab domain or subdomain matches any domain in the whitelist. Do not check the exact URL. For example, if a user has put "https://mail.google.com/mail/u/0/#inbox" in their whitelist, then all webpages with the domain mail.google.com should match and be part of the whitelist.

  4. Maintain the same function naming scheme, indentation, and comment system that is present in the rest of the Tahir app when writing this feature. All of this should be written in plain javascript, without the use of libraries like jQuery, etc.

NolanChan commented 4 years ago

Hi, I'd love it if Tahir had a whitelist! Is there any progress being made on this?

fushatech commented 4 years ago

@NolanChan Basic whitelist management is working on the chrome version of Tahir, can be downloaded from the github (https://github.com/fushatech/tahir/tree/master/chrome). We pushed the update to the Chrome store and are awaiting review.

fnaeem78 commented 4 years ago

My suggestion is to move the whitelist out of localstorage, optionally, if the user signs in with a google or microsoft account, to get permissions for uploading the to the drive implementations of the providers (dbox/ms/googl). I use multiple browsers with Tahir, ffox, brave, chrome. have to whitelist the same domain across browsers. It be nice to get the whitelist synced across browsers.