fusion-energy / neutronics-workshop

A workshop covering a range of fusion relevant analysis and simulations with OpenMC, DAGMC, Paramak and other open source fusion neutronics tools
MIT License
117 stars 51 forks source link

Update 1_example_neutron_flux_and_units.ipynb #205

Closed davidepettinari closed 1 year ago

davidepettinari commented 1 year ago

Hi, I noticed that where 'energy_for_each_reaction' is calculated there is an error. 17.5e6 eV is converted to J, to do this you need to multiply by 1.60218e-19 J/eV. In the script instead there is multiplication by 2.8e-18 (which is the result of the previous multiplication). I hope I have been helpful. Sorry for the trouble. Have a nice day. Davide

shimwell commented 1 year ago

Many thanks for this improvement. Much appreciated

shimwell commented 1 year ago

I've just changed the merge target to the develop branch