fusion-energy / neutronics-workshop

A workshop covering a range of fusion relevant analysis and simulations with OpenMC, DAGMC, Paramak and other open source fusion neutronics tools
MIT License
111 stars 50 forks source link

Missing geometry definition issues - task_06_simple_csg_geometry #267

Closed JoelLucaAdams closed 5 months ago

JoelLucaAdams commented 5 months ago

Issue description

It looks like the task listed above is missing material definitions in cells 2, 3 and 4

Code example

It should look like this:

blanket_cell = openmc.Cell(region=blanket_region)
blanket_cell.fill = lithium_mat  # this assigns a material to a cell

Currently looks like:

blanket_cell = openmc.Cell(region=blanket_region)
shimwell commented 5 months ago

Thansk for raising the issue

I think this is actually ok, cells 2, 3, and 4 plot the geometry by cells

it is not till the 5 code block where the materials are added and we plot by material

JoelLucaAdams commented 5 months ago

Yeah that makes a lot of sense, I'll close the issue then