search

fusion-energy / neutronics-workshop

A workshop covering a range of fusion relevant analysis and simulations with OpenMC, DAGMC, Paramak and other open source fusion neutronics tools
MIT License
124 stars 53 forks source link

Create example with weight windows #71

Open shimwell opened 2 years ago

shimwell commented 2 years ago

I'm hoping to add an example with weight windows and a mesh tally

I am working on this addition on this branch https://github.com/fusion-energy/neutronics-workshop/tree/adding_ww_task

shimwell commented 2 years ago

a half completed example is now on the develop branch as task 13

I shall come back to this once automatic weight windows are added

janmalec commented 1 year ago

Hello, is there any progress on this? The branch adding_www_task does not seem to be available anymore.

shimwell commented 1 year ago

I've been using weight windows along with the magic method and working on this but we noticed a few bugs when iteratively building up weight windows recently. Patrick merged in some fixes to the development branch of OpenMC.

https://github.com/openmc-dev/openmc/pull/2284 https://github.com/openmc-dev/openmc/pull/2275

I have not yet had time to get back on this task but I have a deadline to finish it before Christmas as I need it elsewhere.

shimwell commented 1 year ago

The branch was merged in and probably deleted. But as it was merged the contents are in the repo

https://github.com/fusion-energy/neutronics-workshop/tree/main/tasks/task_13_variance_reduction

I don't think this task is finished and these examples need a tidy up. I shall fix it up soon

shimwell commented 1 year ago

Just reporting progress, there is an open pull request now to redo task 13

tagging @billingsley-john just in case it is of interest

Here is a link to the new files https://github.com/fusion-energy/neutronics-workshop/tree/updating_vr_example/tasks/task_13_variance_reduction