New mesh classes - Githubissues

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.

https://openmc-dagmc-wrapper.readthedocs.io/

MIT License

7 stars 2 forks source link

New mesh classes #108

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

This PR adds new mesh classes RegularMesh2D and UnstructuredMesh.

This shows that MeshTally2D and TetMeshTally don't add much more apart from an enforced name. They could be removed which would save up a ton of maintainance

shimwell commented 2 years ago

Discussed this with Remi on Zoom, this PR looks fine, feel free to merge

shimwell commented 2 years ago

The tests are failing as they are trying to download a file from a CI release. Unfortunately that file is not being uploaded https://github.com/fusion-energy/fusion_neutronics_workflow/runs/5193823571?check_suite_focus=true

The dockerfile for the CI for the CI release is now building so some progress, but now we have a new error when uploading the files