search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

Allowing score to be set directly #111

Closed shimwell closed 2 years ago

shimwell commented 2 years ago

Instead of lumping the scores into tally type this PR allows users to set score directly

This adds more flexibility and simplifies the code a little

codecov[bot] commented 2 years ago

Codecov Report

Merging #111 (76fbb0a) into develop (073641d) will decrease coverage by 2.80%. The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
- Coverage    82.38%   79.58%   -2.81%     
===========================================
  Files           14       14              
  Lines          352      338      -14     
===========================================
- Hits           290      269      -21     
- Misses          62       69       +7
Impacted Files Coverage Δ
...agmc_wrapper/tallies/mesh_tallies/mesh_tally_2D.py 100.00% <ø> (ø)
...agmc_wrapper/tallies/mesh_tallies/mesh_tally_3D.py 100.00% <ø> (ø)
openmc_dagmc_wrapper/Tally.py 87.50% <93.75%> (-12.50%) :arrow_down:
openmc_dagmc_wrapper/tallies/__init__.py 100.00% <100.00%> (ø)
openmc_dagmc_wrapper/tallies/cell_tally.py 100.00% <100.00%> (+4.76%) :arrow_up:
...nmc_dagmc_wrapper/tallies/mesh_tallies/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 073641d...76fbb0a. Read the comment docs.