Tallies names should not be overwritten by ODW

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.

https://openmc-dagmc-wrapper.readthedocs.io/

MIT License

7 stars 2 forks source link

Tallies names should not be overwritten by ODW #115

Open RemDelaporteMathurin opened 2 years ago

RemDelaporteMathurin commented 2 years ago

Currently, if users set a tally name on instanciation, it gets overwritten:

my_tally = odw.CellTally(
    "(n,Xa)", target="copper", materials=materials, name="my_custom_name"
)

I think it can be set afterwards, but that's confusing.

shimwell commented 2 years ago

Yep agreed we shouldn't overwrite names, perhaps it could check if there is a name and if not then set it