search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

Using bounding box for mesh #35

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

This PR makes use of the new bounding_box attribute to set the mesh corners in the event that mesh corners are not specifically set. This has the benefit of ensuring your mesh covers the geometry.

Previously it was difficult to center the mesh and ensure the mesh overlays the whole geometry

The dagmc geometry bounding_box can be found with the previously adde find_bounding_box method. For the time being this includes the graveyard but that will soon be changed on DAGMC develop branch.

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (513cea8) into develop (3d36c9e) will increase coverage by 3.17%. The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
+ Coverage    90.69%   93.86%   +3.17%     
===========================================
  Files            3        3              
  Lines          516      522       +6     
===========================================
+ Hits           468      490      +22     
+ Misses          48       32      -16
Impacted Files Coverage Δ
paramak_neutronics/neutronics_model.py 94.04% <81.81%> (+5.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdba16d...513cea8. Read the comment docs.