Method export_xml should be refactored a bit

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.

https://openmc-dagmc-wrapper.readthedocs.io/

MIT License

7 stars 2 forks source link

Method export_xml should be refactored a bit #55

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

Currently the method NeutronicsModel.export_xml is like 450 line long which makes it hard to read and also hard to override when needed.

Maybe it could be split into at least three parts as the tet_mesh_filename, mesh_tally_3D and mesh_tally_2D seem independent enough

shimwell commented 2 years ago

yep totally agree, this has been getting larger and larger. I did have a go at this a while back on the refactor_tallies branch but I think that can be ignored now as it is so out of date.