NeutronicsModel.export_xml() should accept a geometry argument

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.

https://openmc-dagmc-wrapper.readthedocs.io/

MIT License

7 stars 2 forks source link

NeutronicsModel.export_xml() should accept a geometry argument #56

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

If reflective surfaces are required, the variable geom in NeutronicsModel.export_xml() needs to be modified accordingly.

Currently, the only way of achieving this is to completely override the NeutronicsModel.export_xml() method.

It would be more convenient if an openmc.Geometry object could be passed.

shimwell commented 2 years ago

Yep I can do this, it is getting a bit messy having the .simulate call the export_xml method so might be best to require the user to call the export_xml