search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

refactoring method arguments and adding reflecting planes #59

Closed shimwell closed 2 years ago

shimwell commented 2 years ago

This PR changes the code a little.

users must now used the export_xml() method to create the xml files prior to using .simulate()

This allows for code simplification at the expense of a little extra work for the users

The option to add csg reflecting surfaces to the model is also now possible thanks to @RemDelaporteMathurin

shimwell commented 2 years ago

Looks lie diff_between_angles is undefined on line 132 in openmc_dagmc_wrapper/neutronics_model.py

RemDelaporteMathurin commented 2 years ago

Looks lie diff_between_angles is undefined on line 132 in openmc_dagmc_wrapper/neutronics_model.py

@Shimwell it seems you forgot to bring this is during the conflicting merge on the other PR

shimwell commented 2 years ago

Great, that last commit fixed the GH CI with install