search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

Major refactoring to use OpenMC classes #61

Closed shimwell closed 2 years ago

shimwell commented 2 years ago

As discussed in #60 this PR with work by Remi refactors the code so that openmc classes become the base class for all the classes in the openmc_dagmc_wrapper.

This allows greater flexibility when using the package and eases the testing

codecov[bot] commented 2 years ago

Codecov Report

Merging #61 (c73458e) into main (a5a421e) will decrease coverage by 8.46%. The diff coverage is 85.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   93.86%   85.40%   -8.47%     
==========================================
  Files           3        6       +3     
  Lines         522      514       -8     
==========================================
- Hits          490      439      -51     
- Misses         32       75      +43
Impacted Files Coverage Δ
openmc_dagmc_wrapper/Geometry.py 38.77% <38.77%> (ø)
openmc_dagmc_wrapper/utils.py 89.28% <89.28%> (ø)
openmc_dagmc_wrapper/Tally.py 89.58% <89.58%> (ø)
openmc_dagmc_wrapper/Materials.py 97.36% <97.36%> (ø)
openmc_dagmc_wrapper/Settings.py 100.00% <100.00%> (ø)
openmc_dagmc_wrapper/__init__.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14474cd...c73458e. Read the comment docs.