search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

Larger vacuum radius needed #70

Closed shimwell closed 2 years ago

shimwell commented 3 years ago

I think the largest_radius = max(max(bbox[0]), max(bbox[1])) logic when setting the radius of the vacuum boundary condition is not quite correct and cuts of the corners of the geometry within the sphere. Might have to add some trigonometry here

RemDelaporteMathurin commented 2 years ago

I can't get my head around it but maybe a safety factor of say 3 could do the trick

RemDelaporteMathurin commented 2 years ago

@shimwell I think we can close this now