search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

Fix bounding box tests #87

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

This PR should fix the current failing tests in master.

Although there is a 404 not found error that needs to be fixed. As if CircleCI wasn't able to access the archives.

Which is weird cause the following works locally:

import urllib.request
from pathlib import Path

if not Path("tests/v0.0.2.tar.gz").is_file():
    url = "https://github.com/fusion-energy/neutronics_workflow/archive/refs/tags/v0.0.2.tar.gz"
    urllib.request.urlretrieve(url, "tests/v0.0.2.tar.gz")
shimwell commented 2 years ago

Thanks for this, looks good. feel free to merge when you like

RemDelaporteMathurin commented 2 years ago

I don't think this should be merged until that 404 error is fixed cause we don't know for sure it can fix the issue.

RemDelaporteMathurin commented 2 years ago

I don't think this should be merged until that 404 error is fixed cause we don't know for sure this fix actually works until the CI works again

shimwell commented 2 years ago

Moved tests and functionality to dagmc-bounding-box package so this pr is no longer needed