search

fusion-energy / openmc-dagmc-wrapper

A Python package that extends OpenMC base classes to provide convenience features and standardized tallies when simulating DAGMC geometry with OpenMC.
https://openmc-dagmc-wrapper.readthedocs.io/
MIT License
7 stars 2 forks source link

Adding offset to bounding box #90

Closed shimwell closed 2 years ago

shimwell commented 2 years ago

This PR removes the option to pass a dagmc.h5m file in to the bounding_box argument. This has now been replaced with the dagmc_bounding_box package.

codecov[bot] commented 2 years ago

Codecov Report

Merging #90 (3d0dbc6) into develop (179e534) will increase coverage by 1.48%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #90      +/-   ##
===========================================
+ Coverage    83.60%   85.09%   +1.48%     
===========================================
  Files            6        6              
  Lines          366      322      -44     
===========================================
- Hits           306      274      -32     
+ Misses          60       48      -12
Impacted Files Coverage Δ
openmc_dagmc_wrapper/utils.py 64.91% <10.52%> (-26.27%) :arrow_down:
openmc_dagmc_wrapper/Geometry.py 77.77% <100.00%> (+39.00%) :arrow_up:
openmc_dagmc_wrapper/Tally.py 88.88% <100.00%> (+0.38%) :arrow_up:
openmc_dagmc_wrapper/__init__.py 100.00% <100.00%> (ø)
openmc_dagmc_wrapper/Materials.py 100.00% <0.00%> (+2.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c8f6f5...3d0dbc6. Read the comment docs.

shimwell commented 2 years ago

ci tests with github actions and circle ci is passing, overall coverage is up

I think this is ready to merge into develop