search

fusion-energy / openmc-plasma-source

Creates a plasma source as an openmc.source object from input parameters that describe the plasma
MIT License
26 stars 11 forks source link

Location of ring source in FusionRingSource class #18

Closed AI-Pranto closed 2 years ago

AI-Pranto commented 2 years ago

fix #11

codecov[bot] commented 2 years ago

Codecov Report

Merging #18 (d909eaa) into develop (48e256c) will increase coverage by 2.48%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    93.78%   96.27%   +2.48%     
===========================================
  Files            6        6              
  Lines          161      161              
===========================================
+ Hits           151      155       +4     
+ Misses          10        6       -4
Impacted Files Coverage Δ
openmc_plasma_source/point_source.py 86.66% <100.00%> (+13.33%) :arrow_up:
openmc_plasma_source/ring_source.py 88.23% <100.00%> (+11.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48e256c...d909eaa. Read the comment docs.

RemDelaporteMathurin commented 2 years ago

Hi @AI-Pranto thanks for this!

And thank you for spotting the typos "DT"/"DD".

Any chance you could add a test to catch these lines in the CI? I think atm the CI only checks DT cases.

AI-Pranto commented 2 years ago

@RemDelaporteMathurin Sorry for the late, I updated the test case for both FusionRingSource and FusionPointSource.