fusion-energy / openmc-plasma-source

Creates a plasma source as an openmc.source object from input parameters that describe the plasma
MIT License
28 stars 11 forks source link

Improved TokamakSource (no properties) #49

Closed LiamPattinson closed 2 years ago

LiamPattinson commented 2 years ago

This is an alternate take on Pull Request https://github.com/fusion-energy/openmc-plasma-source/pull/48 in which properties are avoided. Both versions behave essentially the same. I'd argue this version is simpler while the other is more robust. I also think the property version leads to a cleaner interface, but may be harder to understand and maintain.

Pros of property version:

Cons of property version:

Let me know which version appeals most, and whether you'd like me to change anything I've added.

RemDelaporteMathurin commented 2 years ago

Hi @LiamPattinson I like the approach of the other PR. If in time we realise it's confusing, it will always be possible to go back to classic checking in the init.