search

fusion-energy / openmc-plasma-source

Creates a plasma source as an openmc.source object from input parameters that describe the plasma
MIT License
26 stars 11 forks source link

Make requirements.txt #5

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

The only dependency here is numpy really, it should be added either as a requirements.txt or in the setup.py

mdfaisal98 commented 2 years ago

Hi @RemDelaporteMathurin, I'm new to open source contribution and would like to work on this issue. Any specific version of numpy required?

RemDelaporteMathurin commented 2 years ago

Hi @mdfaisal98

Thanks for willing to contribute.

I don't think any specific version of numpy is required. However, it's good practice to have a specific version in the requirements. Let's have the current latest version of numpy in the requirements for now 😄

mdfaisal98 commented 2 years ago

Thanks for the info @RemDelaporteMathurin !

mdfaisal98 commented 2 years ago

Hi @RemDelaporteMathurin , I created a new branch off main named requirements and made the changes. But I'm not able to push my changes. Keep getting the following error - git push --set-upstream origin requirements info: please complete authentication in your browser... remote: Permission to fusion-energy/openmc-plasma-source.git denied to mdfaisal98. fatal: unable to access 'https://github.com/fusion-energy/openmc-plasma-source.git/': The requested URL returned error: 403

RemDelaporteMathurin commented 2 years ago

@mdfaisal98 you can't push to this repository because you don't have write access.

First you need to "fork" this repository, clone your fork ("it will be mdfaisal98/openmc-plasma-source ), make the changes, push on your fork, then create a PR (Pull Request)

mdfaisal98 commented 2 years ago

@RemDelaporteMathurin I have raised a PR. Please review it.