search

fusion-energy / openmc-plasma-source

Creates a plasma source as an openmc.source object from input parameters that describe the plasma
MIT License
26 stars 11 forks source link

Added requirements.txt #6

Closed mdfaisal98 closed 2 years ago

mdfaisal98 commented 2 years ago

This PR adds a requirements.txt file to the project, solving #5 .

mdfaisal98 commented 2 years ago

Thank you for the advice @RemDelaporteMathurin . I have updated the PR as per requested.

RemDelaporteMathurin commented 2 years ago

This seems ok to me! Let's merge it!

@mdfaisal98 don't hesitate to leave a star if you like the package :-)

mdfaisal98 commented 2 years ago

@RemDelaporteMathurin Thanks for helping me in my first open source contribution!

shimwell commented 2 years ago

Congrats on the PR super to see contributions

Sorry for getting here a bit late. Just wanted to mention as this code also requires openmc we can see that openmc request numpy version great than or equal to 1.9 numpy>=1.9

https://github.com/openmc-dev/openmc/blob/eacd8f6bba414cac12f65059a3c17226fd0a201f/setup.py#L69

RemDelaporteMathurin commented 2 years ago

Oh did we miss the most important dependency? 😄

@mdfaisal98 do you think you could be up to it?

@Shimwell do we have an example somewhere regarding how to put openmc in the requirements?

mdfaisal98 commented 2 years ago

So I just need to change the version of numpy from 1.21.2 to >=1.9 ?

RemDelaporteMathurin commented 2 years ago

Yes that's it

mdfaisal98 commented 2 years ago

@RemDelaporteMathurin I have made the changes.