search

fusion-energy / openmc-plasma-source

Creates a plasma source as an openmc.source object from input parameters that describe the plasma
MIT License
25 stars 11 forks source link

"shafranov factor" units should be in cm #86

Closed Oliverator closed 6 months ago

Oliverator commented 6 months ago

Hi John,

This is Mario Oliver (KF). I don't have much experience in GitHub so excuse me if this is not the right way to raise a comment on someone else's code.

I detected that in "src/openmc_plasma_source/tokamak_source.py", lines 42-44, shafranov_factor (float) should be defined in cm, not m.

Otherwise, formula in line 330 does not match.

Hope this is useful. Best regards,

Mario

shimwell commented 6 months ago

Thanks Mario

I've put in a pull request to correct the units. Thanks for pointing out the error so clearly.

RemDelaporteMathurin commented 6 months ago

Hi Mario! Good to see you hear!

Thanks for reporting this!

Cheers Rémi