search

fusion-energy / openmc_regular_mesh_plotter

A Python package for plotting OpenMC regular mesh tally results with underlying geometry from neutronics simulations.
MIT License
9 stars 1 forks source link

Patch release 0.2.3 #30

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

@shimwell do you mind if I release 0.2.3? I would like to have the fix #27 in the stable version

shimwell commented 2 years ago

sure go for it @RemDelaporteMathurin

RemDelaporteMathurin commented 2 years ago

The tests are failing for some reason....

shimwell commented 2 years ago

oh that is because coolprop does support python 3.9 and I think the docker image is now python 3.9

RemDelaporteMathurin commented 2 years ago

Ah that's unfortunate

What should I do?

shimwell commented 2 years ago

I have a PR in for the nmm which makes coolprops optional https://github.com/fusion-energy/neutronics_material_maker/pull/16

shimwell commented 2 years ago

ok I've updated neutronics material maker, it can be installed in two ways now

basic install

pip install neutronics-material-maker

install with coolprops that allows equations pressure density temperature for density of coolants

pip install neutronics-material-maker[density]

try rerunning this CI and it should pip install nnm version 1.1.0 which is the new version and does not include coolprops by default

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (b3311a3) into main (71c4688) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #30   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        126     136   +10     
=====================================
- Misses       126     136   +10
Impacted Files Coverage Δ
regular_mesh_plotter/__init__.py 0.00% <0.00%> (ø)
regular_mesh_plotter/core.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71c4688...b3311a3. Read the comment docs.

shimwell commented 2 years ago

It looks like moab is not available on the docker image. Not quite sure what is causing that but I can take a look

shimwell commented 2 years ago

@RemDelaporteMathurin thanks for all your work on this PR, I can release a new version. Sorry it took me a while to get the tests working. When I get time I shall pop back and simplify the CI