search

fusion-energy / openmc_regular_mesh_plotter

A Python package for plotting OpenMC regular mesh tally results with underlying geometry from neutronics simulations.
MIT License
9 stars 1 forks source link

Remove base_plt #34

Closed RemDelaporteMathurin closed 10 months ago

RemDelaporteMathurin commented 2 years ago

https://github.com/fusion-energy/regular_mesh_plotter/blob/c5dbff275d56aaef8ec65fd7d85fc43091e6e8ee/regular_mesh_plotter/core.py#L31-L36

We don't need this as this is redundant and removes flexibility

shimwell commented 2 years ago

I think this allows one to combine two plots together, I believe the dagmc-slice-plotter makes use of this.

RemDelaporteMathurin commented 2 years ago

this (combining plots together) is natively done in matplotlib, not need to have these lines

shimwell commented 2 years ago

I also recall some issue with plotting two separate plots in one script. They use to be combined unintentionally.

But yes feel free to remove/ refactor

shimwell commented 10 months ago

done