search

fusion-energy / openmc_regular_mesh_plotter

A Python package for plotting OpenMC regular mesh tally results with underlying geometry from neutronics simulations.
MIT License
10 stars 1 forks source link

Refactoring #37

Closed RemDelaporteMathurin closed 2 years ago

RemDelaporteMathurin commented 2 years ago

Fixes #33 by exposing all the arguments of imshow to users, granting more flexibility to users

RemDelaporteMathurin commented 2 years ago

The tests pass locally (within the fusion-neutronics-workflow container) I don't quite understand why the conda install of the dependencies doesn't work here.

shimwell commented 2 years ago

Any chance we could branch from develop and merge to develop

codecov[bot] commented 2 years ago

Codecov Report

Merging #37 (175d51d) into develop (c5293d7) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop     #37   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
=======================================
  Files            3       3           
  Lines          136     136           
=======================================
  Misses         136     136
Impacted Files Coverage Δ
regular_mesh_plotter/core.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a452ef...175d51d. Read the comment docs.