search

fusion-energy / paramak

Create parametric 3D fusion reactor CAD and neutronics models
https://fusion-energy.github.io/paramak
MIT License
67 stars 21 forks source link

Wrong argument type in utils.intersect_solid #131

Open RemDelaporteMathurin opened 2 years ago

RemDelaporteMathurin commented 2 years ago

https://github.com/fusion-energy/paramak/blob/bee4f0434309dd3529d320f85d2cc9a819044bc5/paramak/utils.py#L229-L246

In the code above, intersecter is a paramak.Shape but solid is paramak.Shape.solid type.

shimwell commented 2 years ago

I guess we should have it as paramak.Shape.solid or even better the base CadQuery object