search

fusion-energy / paramak

Create parametric 3D fusion reactor CAD and neutronics models
https://paramak.readthedocs.io/en/main/
MIT License
62 stars 18 forks source link

Unexpected blanket shape at divertors with large major radius #145

Open jamesnha opened 2 years ago

jamesnha commented 2 years ago

With a large major radius relative to the minor radius, the blanket can form a strange shape and overlap with the TF coils. Paramak_issue_large_major_radius.pptx

shimwell commented 2 years ago

Thanks for reporting this,

I suspect the error is somewhere in this section of code

The offset from plasma values might not scale well with large major radius values.

Would you be able to share the input used to make this shape.

shimwell commented 2 years ago

Yes I believe the self.major_radius - self.minor_radius offset used does not work well for large radius machines.

shimwell commented 2 years ago

Making a change to 4 of lines in the code can fix this problem

Screenshot from 2021-12-13 17-26-59

Would you be interested in making a pull request to fix this issue?

These lines would need changing https://github.com/fusion-energy/paramak/blob/b5321a4b0238f3b43964b7c25f28437323881748/paramak/parametric_reactors/ball_reactor.py#L399 https://github.com/fusion-energy/paramak/blob/b5321a4b0238f3b43964b7c25f28437323881748/paramak/parametric_reactors/ball_reactor.py#L403 https://github.com/fusion-energy/paramak/blob/b5321a4b0238f3b43964b7c25f28437323881748/paramak/parametric_reactors/ball_reactor.py#L461 https://github.com/fusion-energy/paramak/blob/b5321a4b0238f3b43964b7c25f28437323881748/paramak/parametric_reactors/ball_reactor.py#L465